Re: [PR] [#6361] feat(paimon):Support specifying primary keys during create paimon table by flink [gravitino]

[via GitHub]

hdygxsj commented on code in PR #6362:
URL: https://github.com/apache/gravitino/pull/6362#discussion_r1929677883


##########
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/catalog/BaseCatalog.java:
##########
@@ -521,6 +552,11 @@ protected CatalogBaseTable toFlinkTable(Table table) {
           .column(column.name(), column.nullable() ? flinkType.nullable() : 
flinkType.notNull())
           .withComment(column.comment());
     }
+    Index[] indices = table.index();
+    if (indices != null && indices.length == 1) {

Review Comment:
   No. this means that only one primary key is supported. The Index object also 
stores field information and there can be multiple fields.
   
![image](https://github.com/user-attachments/assets/22e2d49a-edae-40f2-aad1-6bb9a6b2f1f4)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org