sunxiaojian commented on code in PR #6303:
URL: https://github.com/apache/gravitino/pull/6303#discussion_r1925562999
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/iceberg/TestIcebergPropertiesConverter.java:
##########
@@ -50,7 +52,11 @@ void testCatalogPropertiesWithHiveBackend() {
IcebergPropertiesConstants.ICEBERG_CATALOG_URI,
"hive-uri",
IcebergPropertiesConstants.ICEBERG_CATALOG_WAREHOUSE,
- "hive-warehouse"),
+ "hive-warehouse",
Review Comment:
The current unified logic is to automatically add a prefix to parameters
that have not been mapped and have not been added with "Flink. bypass." before
passing them to Gravitino. When setting them, there is no mandatory restriction
that they must include "Flink. bypass, This is also for compatibility with old
logic, but what you said is also reasonable. Let me unify it first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
