jerqi commented on code in PR #6253:
URL: https://github.com/apache/gravitino/pull/6253#discussion_r1925161760
##########
core/src/main/java/org/apache/gravitino/connector/BaseCatalog.java:
##########
@@ -205,10 +205,8 @@ public void
initAuthorizationPluginInstance(IsolatedClassLoader classLoader) {
LOG.info("Authorization provider is not set!");
return;
}
- try {
- BaseAuthorization<?> authorization =
- BaseAuthorization.createAuthorization(classLoader,
authorizationProvider);
-
+ try (BaseAuthorization<?> authorization =
Review Comment:
In my opinion, `Authorization` class is similar to a factory class. It's
weird that the factory class has `close` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
