FANNG1 commented on code in PR #5980: URL: https://github.com/apache/gravitino/pull/5980#discussion_r1921899883
########## core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagPreEvent.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event; + +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.tag.TagChange; + +/** Represents an event triggered before altering a tag. */ +@DeveloperApi +public class AlterTagPreEvent extends TagPreEvent { + + private final TagChange[] changes; + + /** + * Constructs a new AlterTagPreEvent instance. + * + * @param user The user responsible for the operation. + * @param metalake The namespace of the tag. + * @param tagName The name of the tag being altered. + * @param changes The changes being applied to the tag. + */ + public AlterTagPreEvent(String user, String metalake, String tagName, TagChange[] changes) { + super(user, NameIdentifier.of(metalake, tagName)); Review Comment: please use `NameIdentifierUtil.ofTag(metalake, name)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
