jerryshao commented on code in PR #6298:
URL: https://github.com/apache/gravitino/pull/6298#discussion_r1919796615
##########
core/src/main/java/org/apache/gravitino/tag/TagManager.java:
##########
@@ -352,6 +352,15 @@ public String[] associateTagsForMetadataObject(
}));
}
+ private String getNewName(TagChange... changes) {
+ for (TagChange change : changes) {
+ if (change instanceof TagChange.RenameTag) {
+ return ((TagChange.RenameTag) change).getNewName();
+ }
+ }
+ return null;
Review Comment:
You can get the new name from the updated tag entity, no need to do it here.
Also, it is not proper to return null, which will be weird for the printed log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
