jerqi commented on PR #6271:
URL: https://github.com/apache/gravitino/pull/6271#issuecomment-2597385383

   > > > > I am concerned that this will introduce extra dependencies that may 
conflict with Spark runtime jars. Could you analysis which jars are introduced 
and could we shade them?
   > > > 
   > > > 
   > > > @FANNG1 The dependency of caffeine is relatively simple, and there are 
currently no packages that conflict with Spark. Spark itself does not depend on 
caffeine, so there should be no need shade them yet
   > > 
   > > 
   > > You should shade caffeine Because caffeine may be used by other projects 
like Iceberg. Caffeine is a common libary.
   > 
   > ok, I got it, have another question, Do all references in Gravitino need 
to be shaded ?
   
   You just need to shade the most common libraries.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to