This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new eb3fb31685 [#6239] fix: No need for toString() on string (CLI) (#6247)
eb3fb31685 is described below
commit eb3fb31685c4b93d6722309363c523e25993c3b3
Author: Xiaojian Sun <sunxiaojian...@163.com>
AuthorDate: Thu Jan 16 04:25:28 2025 +0800
[#6239] fix: No need for toString() on string (CLI) (#6247)
### What changes were proposed in this pull request?
Remove unnecessary toSrting() from CLI
### Why are the changes needed?
Fix: [#(6239)](https://github.com/apache/gravitino/issues/6239)
### Does this PR introduce _any_ user-facing change?
N/A
### How was this patch tested?
N/A
---
.../java/org/apache/gravitino/cli/commands/AllMetalakeDetails.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListColumns.java | 2 +-
.../main/java/org/apache/gravitino/cli/commands/ListEntityTags.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListGroups.java | 2 +-
.../main/java/org/apache/gravitino/cli/commands/ListProperties.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListRoles.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListSchema.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListTables.java | 2 +-
.../src/main/java/org/apache/gravitino/cli/commands/ListUsers.java | 4 ++--
.../src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java | 2 --
.../src/main/java/org/apache/gravitino/cli/commands/UserDetails.java | 2 +-
14 files changed, 14 insertions(+), 16 deletions(-)
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/AllMetalakeDetails.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/AllMetalakeDetails.java
index 07d61dcaa7..b76138cb5c 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/AllMetalakeDetails.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/AllMetalakeDetails.java
@@ -55,6 +55,6 @@ public class AllMetalakeDetails extends Command {
String all = Joiner.on(System.lineSeparator()).join(metalakeDetails);
- System.out.print(all.toString());
+ System.out.print(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java
index 7217d5ad3b..58188c38a3 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/GroupDetails.java
@@ -62,6 +62,6 @@ public class GroupDetails extends Command {
String all = roles.isEmpty() ? "The group has no roles." :
String.join(",", roles);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java
index cded12808d..e3bd42ae04 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java
@@ -55,6 +55,6 @@ public class ListAllTags extends Command {
String all = tags.length == 0 ? "No tags exist." : String.join(",", tags);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java
index f3e8e0125c..e1d8eac208 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListColumns.java
@@ -94,6 +94,6 @@ public class ListColumns extends TableCommand {
+ System.lineSeparator());
}
- System.out.print(all.toString());
+ System.out.print(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListEntityTags.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListEntityTags.java
index a1c316fbdf..c0dc501732 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListEntityTags.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListEntityTags.java
@@ -93,6 +93,6 @@ public class ListEntityTags extends Command {
String all = String.join(",", tags);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java
index d00ba3e6ba..cb46b7953c 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListFilesets.java
@@ -73,6 +73,6 @@ public class ListFilesets extends Command {
String all = filesets.length == 0 ? "No filesets exist." :
Joiner.on(",").join(filesets);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java
index a517b4daed..844b8e21d0 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListGroups.java
@@ -55,6 +55,6 @@ public class ListGroups extends Command {
String all = groups.length == 0 ? "No groups exist." : String.join(",",
groups);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListProperties.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListProperties.java
index 56c8fb8ba7..a7d08ba36e 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListProperties.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListProperties.java
@@ -51,6 +51,6 @@ public class ListProperties extends Command {
all.append(property.getKey() + "," + property.getValue() +
System.lineSeparator());
}
- System.out.print(all.toString());
+ System.out.print(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListRoles.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListRoles.java
index 2ecb35bd09..760fe21e3b 100644
--- a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListRoles.java
+++ b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListRoles.java
@@ -55,6 +55,6 @@ public class ListRoles extends Command {
String all = roles.length == 0 ? "No roles exist." : String.join(",",
roles);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchema.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchema.java
index 110a6477a6..695f44d42d 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchema.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListSchema.java
@@ -62,6 +62,6 @@ public class ListSchema extends Command {
String all = schemas.length == 0 ? "No schemas exist." :
Joiner.on(",").join(schemas);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java
index 41a71e87c0..515fb28678 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListTables.java
@@ -66,6 +66,6 @@ public class ListTables extends TableCommand {
? "No tables exist."
: Joiner.on(System.lineSeparator()).join(tableNames);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListUsers.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListUsers.java
index a70176dcfc..3df4b7ca6b 100644
--- a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListUsers.java
+++ b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListUsers.java
@@ -53,8 +53,8 @@ public class ListUsers extends Command {
exitWithError(exp.getMessage());
}
- String all = String.join(",", users);
+ String all = users.length == 0 ? "No users exist." : String.join(",",
users);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java
index 3503d5eb7b..e82d0da470 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UntagEntity.java
@@ -19,7 +19,6 @@
package org.apache.gravitino.cli.commands;
-import com.google.common.base.Joiner;
import org.apache.gravitino.Catalog;
import org.apache.gravitino.NameIdentifier;
import org.apache.gravitino.Schema;
@@ -33,7 +32,6 @@ import org.apache.gravitino.exceptions.NoSuchTableException;
import org.apache.gravitino.rel.Table;
public class UntagEntity extends Command {
- public static final Joiner COMMA_JOINER = Joiner.on(", ").skipNulls();
protected final String metalake;
protected final FullName name;
protected final String[] tags;
diff --git
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java
index e37f8e6f13..d89597d169 100644
---
a/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java
+++
b/clients/cli/src/main/java/org/apache/gravitino/cli/commands/UserDetails.java
@@ -62,6 +62,6 @@ public class UserDetails extends Command {
String all = roles.isEmpty() ? "The user has no roles." : String.join(",",
roles);
- System.out.println(all.toString());
+ System.out.println(all);
}
}
