FANNG1 commented on code in PR #6224:
URL: https://github.com/apache/gravitino/pull/6224#discussion_r1915854991
##########
flink-connector/flink/src/test/java/org/apache/gravitino/flink/connector/integration/test/FlinkCommonIT.java:
##########
@@ -72,6 +72,10 @@ protected boolean
supportSchemaOperationWithCommentAndOptions() {
return true;
}
+ protected Map<String, String> schemaOptions(String warehouse, String
schemaName) {
Review Comment:
How about chang `doWithSchema` to non-static? It'a little hacky and hard to
maintenance to add ` schemaOptions(warehouse, databaseName)` to all
`doWithSchema` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
