justinmclean commented on code in PR #6227:
URL: https://github.com/apache/gravitino/pull/6227#discussion_r1914515075
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##########
@@ -98,14 +91,7 @@ public void handleSimpleLine() {
if (line.hasOption(GravitinoOptions.HELP)) {
displayHelp(options);
}
- /* Display Gravitino client version. */
- else if (line.hasOption(GravitinoOptions.VERSION)) {
- newClientVersion(getUrl(), ignore).handle();
- }
- /* Display Gravitino server version. */
- else if (line.hasOption(GravitinoOptions.SERVER)) {
- newServerVersion(getUrl(), ignore).handle();
- }
+ new SimpleCommandHandler(this, line, ignore).handle();
Review Comment:
While not strictly needed, having an else here makes sense - no need to
create something if it's not required and SimpleCommandHandler may have
unexpected side effects at some future point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
