tengqm commented on code in PR #5942:
URL: https://github.com/apache/gravitino/pull/5942#discussion_r1895111200
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListCatalogs.java:
##########
@@ -49,7 +49,11 @@ public void handle() {
try {
GravitinoClient client = buildClient(metalake);
catalogs = client.listCatalogsInfo();
- output(catalogs);
+ if (catalogs.length == 0) {
+ System.out.println("No catalogs exists.");
+ } else {
+ output(catalogs);
+ }
Review Comment:
It is odd to call `System.out.println` in one branch and `output` in
another, unless there is an implicit protocol.
##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListAllTags.java:
##########
@@ -53,7 +53,7 @@ public void handle() {
exitWithError(exp.getMessage());
}
- String all = String.join(",", tags);
+ String all = tags.length == 0 ? "No tags exists." : String.join(",", tags);
Review Comment:
"No tags" is still a plural.
```suggestion
String all = tags.length == 0 ? "No tags exist." : String.join(",",
tags);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
