(gravitino) branch main updated: [#5828] improvement(CLI): Slightly misleading error message when user is not specified in Gravitino CLI (#5921)

[jmclean]

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 9aa8f53f4 [#5828] improvement(CLI): Slightly misleading error message 
when user is not specified in Gravitino CLI (#5921)
9aa8f53f4 is described below

commit 9aa8f53f4ca231fe4250e264973785ad17c3f66f
Author: Lord of Abyss <103809695+abyss-l...@users.noreply.github.com>
AuthorDate: Fri Dec 20 15:22:19 2024 +0800

    [#5828] improvement(CLI): Slightly misleading error message when user is 
not specified in Gravitino CLI (#5921)
    
    ### What changes were proposed in this pull request?
    
    Fix missing leading error message when user is not specified in
    Gravitino CLI, include all commands.
    
    ### Why are the changes needed?
    
    Fix: #5828
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    ```bash
    bin/gcli.sh  user create --metalake demo_metalake
    # Missing --user option.
    
    bin/gcli.sh  user details --metalake demo_metalake
    # Missing --user option.
    
    bin/gcli.sh  user delete --metalake demo_metalake
    # Missing --user option.
    
    bin/gcli.sh  user list --metalake demo_metalake
    # anonymous
    ```
---
 .../cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java    | 1 +
 .../src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java | 5 +++++
 2 files changed, 6 insertions(+)

diff --git 
a/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java 
b/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java
index 323f0fc2a..3af83b32a 100644
--- a/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java
+++ b/clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java
@@ -30,6 +30,7 @@ public class ErrorMessages {
   public static final String UNKNOWN_TABLE = "Unknown table name.";
   public static final String MALFORMED_NAME = "Malformed entity name.";
   public static final String MISSING_NAME = "Missing --name option.";
+  public static final String MISSING_USER = "Missing --user option.";
   public static final String METALAKE_EXISTS = "Metalake already exists.";
   public static final String CATALOG_EXISTS = "Catalog already exists.";
   public static final String SCHEMA_EXISTS = "Schema already exists.";
diff --git 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
index 8b7e65c32..d651572e3 100644
--- 
a/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
+++ 
b/clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
@@ -479,6 +479,11 @@ public class GravitinoCommandLine extends 
TestableCommandLine {
 
     Command.setAuthenticationMode(auth, userName);
 
+    if (user == null && !CommandActions.LIST.equals(command)) {
+      System.err.println(ErrorMessages.MISSING_USER);
+      return;
+    }
+
     switch (command) {
       case CommandActions.DETAILS:
         if (line.hasOption(GravitinoOptions.AUDIT)) {