FANNG1 commented on code in PR #5682: URL: https://github.com/apache/gravitino/pull/5682#discussion_r1891759911
########## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/SecureHadoopCatalogOperations.java: ########## @@ -50,28 +61,33 @@ import org.apache.gravitino.file.FilesetChange; import org.apache.gravitino.meta.FilesetEntity; import org.apache.gravitino.meta.SchemaEntity; +import org.apache.gravitino.utils.NameIdentifierUtil; import org.apache.gravitino.utils.PrincipalUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @SuppressWarnings("removal") public class SecureHadoopCatalogOperations - implements CatalogOperations, SupportsSchemas, FilesetCatalog { + implements CatalogOperations, SupportsSchemas, FilesetCatalog, SupportsCredentialOperations { public static final Logger LOG = LoggerFactory.getLogger(SecureHadoopCatalogOperations.class); private final HadoopCatalogOperations hadoopCatalogOperations; + private CatalogCredentialManager catalogCredentialManager; Review Comment: Let me think more, what's different for Credential operations is the classloader, it should load the credential provider in catalog classloader. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org