diqiu50 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1869456418
########## clients/filesystem-fuse/src/filesystem_metadata.rs: ########## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use crate::filesystem::FileStat; +use fuse3::Errno; +use std::collections::HashMap; + +/// IFileSystemMetadata is an interface that defines the operations to manage file metadata. +pub trait IFileSystemMetadata { + fn add_file(&mut self, parent_inode: u64, name: &str) -> FileStat; + + fn add_file_with_name(&mut self, name: &str, parent: &str) -> FileStat; + + fn add_root_dir(&mut self) -> FileStat; + + fn add_dir(&mut self, parent_inode: u64, name: &str) -> FileStat; + + fn add_dir_with_name(&mut self, parent: &str, name: &str) -> FileStat; + + fn get_file(&self, inode: u64) -> Option<FileStat>; + + fn get_file_from_dir(&self, parent_inode: u64, name: &str) -> Option<FileStat>; + + fn get_dir_childs(&self, inode: u64) -> Vec<FileStat>; + + fn update_file_stat(&mut self, file_id: u64, file_stat: &FileStat); + + fn remove_file(&mut self, parent_file_id: u64, name: &str) -> Result<(), Errno>; + + fn remove_dir(&mut self, parent_file_id: u64, name: &str) -> Result<(), Errno>; + + fn get_file_path(&self, file_id: u64) -> String; +} + +/// DefaultFileSystemMetadata is a simple implementation of FileSystemMetadata +/// that stores file metadata in memory. +pub struct DefaultFileSystemMetadata { + // file_stat_map stores the metadata of all files. + file_stat_map: HashMap<u64, FileStat>, + + // dir_name_map stores the inode of a directory by its full path of mount point. + dir_name_map: HashMap<String, u64>, + + // dir_child_map stores the children of a directory. + dir_child_map: HashMap<u64, HashMap<String, u64>>, + + // inode_id_generator is used to generate unique inode IDs. + inode_id_generator: u64, +} + +impl DefaultFileSystemMetadata { + pub fn new() -> Self { + Self { + file_stat_map: Default::default(), + dir_name_map: Default::default(), + dir_child_map: Default::default(), + inode_id_generator: 1000000, + } + } + + pub(crate) fn next_inode_id(&mut self) -> u64 { + self.inode_id_generator += 1; + self.inode_id_generator + } +} + +impl IFileSystemMetadata for DefaultFileSystemMetadata { + fn get_file_path(&self, file_id: u64) -> String { + self.file_stat_map + .get(&file_id) + .map(|x| x.path.clone()) + .unwrap_or_else(|| "".to_string()) + } + + fn add_file_with_name(&mut self, name: &str, parent: &str) -> FileStat { + let parent_inode = self.dir_name_map.get(parent).unwrap(); + self.add_file(*parent_inode, name) + } + + fn add_file(&mut self, parent_inode: u64, name: &str) -> FileStat { + let file_stat = FileStat::new_file(name, self.next_inode_id(), parent_inode); + self.file_stat_map + .insert(file_stat.inode, FileStat::clone(&file_stat)); + self.dir_child_map + .entry(parent_inode) + .or_insert(HashMap::new()) + .insert(name.to_string(), file_stat.inode); + file_stat + } + + fn add_root_dir(&mut self) -> FileStat { + let file_stat = FileStat::new_dir("", 1, 0); + self.file_stat_map + .insert(file_stat.inode, FileStat::clone(&file_stat)); + self.dir_child_map.insert(file_stat.inode, HashMap::new()); + + self.dir_name_map + .insert(file_stat.name.clone(), file_stat.inode); + file_stat + } + + fn add_dir(&mut self, parent_inode: u64, name: &str) -> FileStat { + let file_stat = FileStat::new_dir(name, self.next_inode_id(), parent_inode); + self.file_stat_map + .insert(file_stat.inode, FileStat::clone(&file_stat)); + self.dir_child_map.insert(file_stat.inode, HashMap::new()); + self.dir_child_map + .get_mut(&parent_inode) + .unwrap() + .insert(name.to_string(), file_stat.inode); + + let parent = self.file_stat_map.get(&parent_inode).unwrap().clone(); + let full_name = format!("{}/{}", parent.path, name); + self.dir_name_map.insert(full_name, file_stat.inode); + file_stat + } + + fn add_dir_with_name(&mut self, parent: &str, name: &str) -> FileStat { + let parent_inode = self.dir_name_map.get(parent).unwrap().clone(); Review Comment: Ok, I understand. I will only use unwrap when it is guaranteed to succeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
