alan910127 commented on code in PR #5738: URL: https://github.com/apache/gravitino/pull/5738#discussion_r1867472216
########## clients/filesystem-fuse/src/filesystem.rs: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use fuse3::{Errno, FileType, Timestamp}; +use std::time::SystemTime; + +/// File system interface for the file system implementation. it use by FuseApiHandle +/// the `file_id` and `parent_file_id` it is the unique identifier for the file system, it is used to identify the file or directory +/// the `fh` it is the file handle, it is used to identify the opened file, it is used to read or write the file content +pub trait IFileSystem: Send + Sync { Review Comment: We usually don't prefix traits because they are inherently distinguishable from types, even at the syntax level. We can directly use `FileSystem` here. ########## clients/filesystem-fuse/src/file_handle_manager.rs: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use crate::filesystem::{FileStat, OpenedFile}; +use std::collections::HashMap; +use std::sync::atomic::AtomicU64; + +// FileHandleManager is a manager for opened files. Review Comment: Comments could be transformed into doc comments. ```suggestion /// FileHandleManager is a manager for opened files. ``` ########## clients/filesystem-fuse/src/filesystem_metadata.rs: ########## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use crate::filesystem::FileStat; +use fuse3::Errno; +use std::collections::HashMap; + +/// IFileSystemMetadata is an interface that defines the operations to manage file metadata. +pub trait IFileSystemMetadata { + + fn add_file(&mut self, parent_inode: u64, name :&str) -> FileStat; + + fn add_file_with_name(&mut self, name :&str, parent: &str) -> FileStat; + + fn add_root_dir(&mut self) -> FileStat; + + fn add_dir(&mut self, parent_inode: u64, name :&str) -> FileStat; + + fn add_dir_with_name(&mut self, parent :&str, name: &str) -> FileStat; + + fn get_file(&self, inode: u64) -> Option<FileStat>; + + fn get_file_from_dir(&self, parent_inode:u64, name: &str) -> Option<FileStat>; + + fn get_dir_childs(&self, inode: u64) -> Vec<FileStat>; + + fn update_file_stat(&mut self, file_id: u64, file_stat: &FileStat); + + fn remove_file(&mut self, parent_file_id: u64, name: &str) -> Result<(), Errno>; + + fn remove_dir(&mut self, parent_file_id: u64, name: &str) -> Result<(), Errno>; + + fn get_file_path(&self, file_id: u64) -> String; +} + +/// DefaultFileSystemMetadata is a simple implementation of FileSystemMetadata +/// that stores file metadata in memory. +pub struct DefaultFileSystemMetadata { + + // file_stat_map stores the metadata of all files. + file_stat_map: HashMap<u64, FileStat>, + + // dir_name_map stores the inode of a directory by its full path of mount point. + dir_name_map: HashMap<String, u64>, + + // dir_child_map stores the children of a directory. + dir_child_map: HashMap<u64, HashMap<String, u64>>, + + // inode_id_generator is used to generate unique inode IDs. + inode_id_generator: u64, +} + +impl DefaultFileSystemMetadata{ Review Comment: Format? ########## clients/filesystem-fuse/src/filesystem.rs: ########## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use fuse3::{Errno, FileType, Timestamp}; +use std::time::SystemTime; + +/// File system interface for the file system implementation. it use by FuseApiHandle +/// the `file_id` and `parent_file_id` it is the unique identifier for the file system, it is used to identify the file or directory +/// the `fh` it is the file handle, it is used to identify the opened file, it is used to read or write the file content +pub trait IFileSystem: Send + Sync { Review Comment: We usually don't prefix traits because they are inherently distinguishable from types, even at the syntax level. We can directly use `FileSystem` here. ########## clients/filesystem-fuse/src/file_handle_manager.rs: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +use crate::filesystem::{FileStat, OpenedFile}; +use std::collections::HashMap; +use std::sync::atomic::AtomicU64; + +// FileHandleManager is a manager for opened files. Review Comment: Comments could be transformed into doc comments. ```suggestion /// FileHandleManager is a manager for opened files. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
