justinmclean commented on code in PR #5716:
URL: https://github.com/apache/gravitino/pull/5716#discussion_r1867004360
##########
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java:
##########
@@ -81,6 +87,11 @@ public Options options() {
"z", PROVIDER, "provider one of hadoop, hive, mysql, postgres,
iceberg, kafka"));
options.addOption(createArgOption("l", USER, "user name"));
options.addOption(createArgOption("g", GROUP, "group name"));
+ options.addOption(createArgOption(DATATYPE, "column data type"));
+ options.addOption(createArgOption(POSITION, "position of column"));
+ options.addOption(createArgOption(NULL, "column value can be null
(true/false)"));
Review Comment:
Null is an adjective, not a noun. A column can be nullable, but can have a
null value or allow nulls. I selected NULL as that is similar to SQL statements
e.g. "...ALTER COLUMN columnName datatype NULL"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
