justinmclean commented on code in PR #5606:
URL: https://github.com/apache/gravitino/pull/5606#discussion_r1859275498


##########
clients/cli/src/main/java/org/apache/gravitino/cli/commands/Command.java:
##########
@@ -69,4 +77,17 @@ protected GravitinoAdminClient buildAdminClient() {
       return GravitinoAdminClient.builder(url).build();
     }
   }
+
+  /**
+   * Outputs the entity to the console.
+   *
+   * @param entity The entity to output.
+   */
+  protected <T> void output(T entity) {
+    if (outputFormat != null && outputFormat.equals("table")) {
+      TableFormat.output(entity);
+    } else {

Review Comment:
   Sure, but imagine a user is scripting this, having a "--output $format" 
(where $format could be "plain" or "table") would be helpful, and also, more 
formats (e.g.  "JSON") might be added in the future. Putting that check in 
would mean that the script would be more future-proof.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to