diqiu50 commented on code in PR #5632:
URL: https://github.com/apache/gravitino/pull/5632#discussion_r1851448293


##########
trino-connector/integration-test/src/test/resources/trino-ci-testset/trino-cascading-testsets/hive/catalog_hive_prepare.sql:
##########
@@ -0,0 +1,74 @@
+call gravitino.system.create_catalog(
+    'gt_hive1',
+    'hive',
+     MAP(
+        ARRAY['metastore.uris', 'cloud.region-code', 
'cloud.trino.connection-url', 'cloud.trino.connection-user', 
'cloud.trino.connection-password'],
+        ARRAY['${hive_uri}', 'c2', '${trino_remote_jdbc_uri}', 'admin', '']
+    )
+);
+
+call gravitino.system.create_catalog(
+    'gt_hive1_1',
+    'hive',
+    map(
+        array['metastore.uris'],
+        array['${hive_uri}']
+    )
+);
+
+CREATE SCHEMA gt_hive1_1.gt_datatype;
+USE gt_hive1_1.gt_datatype;
+
+CREATE TABLE tb01 (
+    f1 VARCHAR(200),
+    f2 CHAR(20),
+    f3 VARBINARY,
+    f4 DECIMAL(10, 3),
+    f5 REAL,
+    f6 DOUBLE,
+    f7 BOOLEAN,
+    f8 TINYINT,
+    f9 SMALLINT,
+    f10 INT,
+    f11 INTEGER,
+    f12 BIGINT,
+    f13 DATE,
+    f15 TIMESTAMP
+);
+
+INSERT INTO tb01 (f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f15)
+VALUES ('Sample text 1', 'Text1', x'65', 123.456, 7.89, 12.34, false, 1, 100, 
1000, 1000, 100000, DATE '2024-01-01', TIMESTAMP '2024-01-01 08:00:00');
+
+INSERT INTO tb01 (f1, f2, f3, f4, f5, f6, f7, f8, f9, f10, f11, f12, f13, f15)
+VALUES (NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, 
NULL, NULL, NULL);
+
+CREATE TABLE tb02 (name char(255));
+INSERT INTO tb02 (name) VALUES ('Apache Gravitino is a high-performance, 
geo-distributed, and federated metadata lake. It manages metadata directly in 
different sources, types, and regions, providing users with unified metadata 
access for data and AI assets.');
+

Review Comment:
   Is it bad to separate them like this? For example, separating table creation 
and result verification when testing data types. Previously, in the TPC-H 
tests, I created tables and added data in the prepare phase because all the 
tests there were queries.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to