justinmclean commented on code in PR #5293:
URL: https://github.com/apache/gravitino/pull/5293#discussion_r1844592948


##########
docs/cli.md:
##########
@@ -506,6 +507,26 @@ gcli tag update --tag tagA --rename newTag
 gcli tag update --tag tagA --comment "new comment"
 ```
 
+### Owners commands
+
+#### List an owner
+
+```bash
+gcli catalog details --name postgres --owner
+```
+
+#### Set an owner to a user
+
+```bash
+gcli catalog set --name postgres --user admin

Review Comment:
   The two options from a user's point of view look like this:
   ```
   gcli catalog details --name postgres --owner
   gcli catalog verb --name postgres --user admin --owner
   gcli catalog verb --name postgres --group groupA --owner
   ```
   OR
   ```
   gcli catalog details --name postgres --owner
   gcli catalog verb --name postgres --user admin
   gcli catalog verb --name postgres --group groupA
   ```
   
   The first option requires 20% of the code of the second option and is much 
more maintainable. For the second option, we also need to add code when a new 
entity is added, while the first option will work with no extra code when new 
entities are added.
   
   I had first suggested using `update` rather than `set` as the verb to use as 
if you use `set`, then the user has an expectation that `remove` will also 
work, but it will not.
    
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to