xloya commented on code in PR #5209:
URL: https://github.com/apache/gravitino/pull/5209#discussion_r1812541567
##########
clients/client-python/tests/integration/test_gvfs_with_gcs.py:
##########
@@ -129,9 +131,17 @@ def _init_test_entities(cls):
properties=cls.fileset_properties,
)
- os.environ["GOOGLE_APPLICATION_CREDENTIALS"] = cls.key_file
- arrow_gcs_fs = GcsFileSystem()
- cls.fs = ArrowFSWrapper(arrow_gcs_fs)
+ cls.fs = GCSFileSystem(token=cls.key_file)
+
+ # Object storage like GCS does not support making directory and can only
create
Review Comment:
It seems will create the bucket in the code, could we have tests for this
behavior: https://github.com/fsspec/s3fs/blob/main/s3fs/core.py#L904.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
