LauraXia123 commented on code in PR #5164:
URL: https://github.com/apache/gravitino/pull/5164#discussion_r1808257452
##########
web/web/src/app/metalakes/metalake/rightContent/tabsContent/tableView/TableView.js:
##########
@@ -251,31 +262,35 @@ const TableView = () => {
title='Details'
size='small'
sx={{ color: theme => theme.palette.text.secondary }}
- onClick={() => handleShowDetails({ row, type: 'catalog' })}
- data-refer={`view-catalog-${row.name}`}
+ onClick={() => handleShowDetails({ row, type: row.node })}
+ data-refer={`view-entity-${row.name}`}
>
<ViewIcon viewBox='0 0 24 22' />
</IconButton>
- <IconButton
- title='Edit'
- size='small'
- sx={{ color: theme => theme.palette.text.secondary }}
- onClick={() => handleShowEditDialog({ row, type: 'catalog' })}
- data-refer={`edit-catalog-${row.name}`}
- >
- <EditIcon />
- </IconButton>
-
- <IconButton
- title='Delete'
- size='small'
- sx={{ color: theme => theme.palette.error.light }}
- onClick={() => handleDelete({ name: row.name, type: 'catalog',
catalogType: row.type })}
- data-refer={`delete-catalog-${row.name}`}
- >
- <DeleteIcon />
- </IconButton>
+ {!isKafkaSchema && (
+ <IconButton
+ title='Edit'
+ size='small'
+ sx={{ color: theme => theme.palette.text.secondary }}
+ onClick={() => handleShowEditDialog({ row, type: row.node })}
+ data-refer={`edit-entity-${row.name}`}
+ >
+ <EditIcon />
+ </IconButton>
+ )}
+
+ {!isKafkaSchema && (
+ <IconButton
+ title='Delete'
+ size='small'
+ sx={{ color: theme => theme.palette.error.light }}
+ onClick={() => handleDelete({ name: row.name, type: row.node,
catalogType: row.type })}
+ data-refer={`delete-entity-${row.name}`}
+ >
+ <DeleteIcon />
+ </IconButton>
Review Comment:
The version of this PR base does not yet support the hudi catalog, I can
submit another pr for that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
