jerqi commented on code in PR #5023:
URL: https://github.com/apache/gravitino/pull/5023#discussion_r1776501042
##########
core/src/main/java/org/apache/gravitino/storage/relational/JDBCBackend.java:
##########
@@ -382,20 +380,23 @@ public <E extends Entity & HasIdentifier> List<E>
listEntitiesByRelation(
case METADATA_OBJECT_ROLE_REL:
return (List<E>)
RoleMetaService.getInstance()
- .listRolesByMetadataObjectIdentAndType(nameIdentifier,
identType);
+ .listRolesByMetadataObjectIdentAndType(nameIdentifier,
identType, allFields);
case ROLE_GROUP_REL:
if (identType == Entity.EntityType.ROLE) {
return (List<E>)
GroupMetaService.getInstance().listGroupsByRoleIdent(nameIdentifier);
} else {
throw new IllegalArgumentException(
- String.format("ROLE_GROUP_REL doesn't support type %s",
identType.name()));
+ String.format(
+ "ROLE_GROUP_REL doesn't support type %s or loading all
fields",
Review Comment:
Now, we don't support all fields. We can support fetch partial fields in the
next pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
