LiuQhahah commented on PR #4879: URL: https://github.com/apache/gravitino/pull/4879#issuecomment-2370654666
> > > @LiuQhahah #4055 pull request about listing users have been merged. Do you have time to rework this pull request? > > > > > > Hi @jerqi > > what action need i to do ? just close the PR? > > #4055 is the pull request to support to list users. You pull request is to list groups. Two operations are very similar. You can refer to #4055 to modify your pull request. > > There are several points to modify. > > 1. You should add more uts and integration test (You can see AccessControlIT.java). > 2. You should support listGroupNames and listGroup operations. Understood, thanks for the advice! I've been a little busy for a while, so I'll start working on this task today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
