jerryshao commented on code in PR #4942:
URL: https://github.com/apache/gravitino/pull/4942#discussion_r1769506837
##########
catalogs/catalog-lakehouse-hudi/src/main/java/org/apache/gravitino/catalog/lakehouse/hudi/HudiTablePropertiesMetadata.java:
##########
@@ -18,14 +18,28 @@
*/
package org.apache.gravitino.catalog.lakehouse.hudi;
-import java.util.Collections;
+import static
org.apache.gravitino.connector.PropertyEntry.stringImmutablePropertyEntry;
+import static
org.apache.gravitino.connector.PropertyEntry.stringReservedPropertyEntry;
+
+import com.google.common.collect.ImmutableMap;
import java.util.Map;
import org.apache.gravitino.connector.BasePropertiesMetadata;
import org.apache.gravitino.connector.PropertyEntry;
public class HudiTablePropertiesMetadata extends BasePropertiesMetadata {
+ public static final String COMMENT = "comment";
+ public static final String LOCATION = "location";
+ private static final Map<String, PropertyEntry<?>> PROPERTIES_METADATA =
+ ImmutableMap.<String, PropertyEntry<?>>builder()
+ .put(COMMENT, stringReservedPropertyEntry(COMMENT, "table comment",
true /* hidden */))
+ .put(
+ LOCATION,
+ stringImmutablePropertyEntry(
+ LOCATION, "The location for Hudi table", false, null, false,
false))
Review Comment:
Also here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
