Re: [PR] [#4718] fix(iceberg): use unified logic to transform catalog backend name to handle the renaming of catalog [gravitino]

[via GitHub]

FANNG1 commented on code in PR #4900:
URL: https://github.com/apache/gravitino/pull/4900#discussion_r1759726502


##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergConnectorAdapter.java:
##########
@@ -46,7 +46,6 @@ public IcebergConnectorAdapter() {
   @Override
   public Map<String, String> buildInternalConnectorConfig(GravitinoCatalog 
catalog)
       throws Exception {
-    catalog.getProperties().put("catalog-name", catalog.getName());

Review Comment:
   make changes like that?
   ```
   this.properties  = catalog.properties()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org