diqiu50 commented on code in PR #4897: URL: https://github.com/apache/gravitino/pull/4897#discussion_r1756063329
########## catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/OSSProperties.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.storage; + +// Defines the unified OSS properties for different catalogs and connectors. +public class OSSProperties { + + // The endpoint of Aliyun OSS service. + public static final String GRAVITINO_OSS_ENDPOINT = "oss-endpoint"; + // The static access key ID used to access OSS data. + public static final String GRAVITINO_OSS_ACCESS_KEY_ID = "oss-access-key-id"; + // The static secret access key used to access OSS data. + public static final String GRAVITINO_OSS_ACCESS_KEY_SECRET = "oss-access-key-secret"; + Review Comment: The `oss-access-key-secret` is mismatch with the docs. is it right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
