jerryshao commented on code in PR #4858:
URL: https://github.com/apache/gravitino/pull/4858#discussion_r1745918050
##########
core/src/main/java/org/apache/gravitino/catalog/FilesetNormalizeDispatcher.java:
##########
@@ -96,7 +96,9 @@ public boolean dropFileset(NameIdentifier ident) {
@Override
public String getFileLocation(NameIdentifier ident, String subPath) {
- throw new UnsupportedOperationException("Not implemented");
+ // The constraints of the name spec may be more strict than underlying
catalog,
+ // and for compatibility reasons, we only apply case-sensitive
capabilities here.
+ return dispatcher.getFileLocation(normalizeCaseSensitive(ident), subPath);
Review Comment:
I would suggest split the core part logic into another PR. In this PR, we
only focus on client and server side API. Don't make the PR too big, which is
hard to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
