jerryshao commented on code in PR #4846:
URL: https://github.com/apache/gravitino/pull/4846#discussion_r1743097152
##########
core/src/main/java/org/apache/gravitino/storage/relational/mapper/CatalogMetaMapper.java:
##########
@@ -150,7 +150,8 @@ CatalogPO selectCatalogMetaByMetalakeIdAndName(
+ " AND metalake_id = #{oldCatalogMeta.metalakeId}"
+ " AND type = #{oldCatalogMeta.type}"
+ " AND provider = #{oldCatalogMeta.provider}"
- + " AND catalog_comment = #{oldCatalogMeta.catalogComment}"
+ + " AND (catalog_comment = #{oldCatalogMeta.catalogComment} "
+ + " or (catalog_comment is null and
#{oldCatalogMeta.catalogComment} is null))"
Review Comment:
Can you please change to "IS NULL" for reserved words?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
