jerryshao commented on code in PR #4628:
URL: https://github.com/apache/gravitino/pull/4628#discussion_r1742503188
##########
settings.gradle.kts:
##########
@@ -48,7 +48,7 @@ include(
include("iceberg:iceberg-common")
include("iceberg:iceberg-rest-server")
include("authorizations:authorization-ranger")
-include("trino-connector")
+include("trino-connector", "trino-connector:integration-test")
Review Comment:
Why do we choose to moe integration to "trino-connector" as a submodule, not
put them into src/test?
Typically, for a module, there will be "/src" under that module, but here it
has another module under this module, it's not a common practice, I feel a
little weird about this.
##########
settings.gradle.kts:
##########
@@ -48,7 +48,7 @@ include(
include("iceberg:iceberg-common")
include("iceberg:iceberg-rest-server")
include("authorizations:authorization-ranger")
-include("trino-connector")
+include("trino-connector", "trino-connector:integration-test")
Review Comment:
Why do we choose to move integration to "trino-connector" as a submodule,
not put them into src/test?
Typically, for a module, there will be "/src" under that module, but here it
has another module under this module, it's not a common practice, I feel a
little weird about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
