FANNG1 commented on code in PR #4598:
URL: https://github.com/apache/gravitino/pull/4598#discussion_r1728568092
##########
iceberg/iceberg-rest-server/src/main/java/org/apache/gravitino/iceberg/service/IcebergTableOpsManager.java:
##########
@@ -97,8 +126,20 @@ private String shelling(String rawPrefix) {
}
}
+ private void closeIcebergTableOps(IcebergTableOps ops) {
+ try {
+ ops.close();
+ } catch (Exception ex) {
+ LOG.warn("close iceberg table ops fail: {}", ops);
+ throw new RuntimeException(ex);
Review Comment:
what will happen if throwing exception here? I prefer to just print warning
logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
