FANNG1 commented on code in PR #4273:
URL: https://github.com/apache/gravitino/pull/4273#discussion_r1713279514
##########
iceberg/iceberg-common/src/main/java/org/apache/gravitino/iceberg/common/IcebergConfig.java:
##########
@@ -158,6 +158,15 @@ public class IcebergConfig extends Config implements
OverwriteDefaultConfig {
.stringConf()
.create();
+ public static final ConfigEntry<String> ICEBERG_REST_CATALOG_PROVIDER =
+ new ConfigBuilder(IcebergConstants.ICEBERG_REST_CATALOG_PROVIDER)
+ .doc(
+ "The implementation of IcebergTableOpsProvider defines how the
Iceberg REST catalog server gets iceberg catalogs.")
+ .version(ConfigConstants.VERSION_0_6_0)
+ .stringConf()
+ .createWithDefault(
+
"org.apache.gravitino.iceberg.common.ops.ConfigIcebergTableOpsProvider");
Review Comment:
You didn't use ICEBERG_REST_CATALOG_PROVIDER to get the provider below,
It's better to use IcebergConfig
```java
String className =
properties.getOrDefault(
IcebergConstants.ICEBERG_REST_CATALOG_PROVIDER,
ConfigBasedIcebergTableOpsProvider.class.getName());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
