mchades commented on code in PR #4436:
URL: https://github.com/apache/gravitino/pull/4436#discussion_r1710781086
##########
integration-test/trino-it/init/hive/init.sh:
##########
@@ -19,6 +19,6 @@
#
IP=$(hostname -I | awk '{print $1}')
-sed -i "s|<value>hdfs://localhost:9000|<value>hdfs://${IP}:9000|g"
/usr/local/hive/conf/hive-site.xml
+sed -i "s|<value>hdfs://__REPLACE__HOST_NAME:9000|<value>hdfs://${IP}:9000|g"
${HIVE_TMP_CONF_DIR}/hive-site.xml
Review Comment:
The sed command seems unnecessary since the `start.sh` already did the
replace:
https://github.com/apache/gravitino/blob/1ea4860e8abe047f5469ed39b3f43da2d28cd7e5/dev/docker/hive/start.sh#L35
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
