caican00 commented on code in PR #4349:
URL: https://github.com/apache/gravitino/pull/4349#discussion_r1705044809
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonCatalogOperations.java:
##########
@@ -457,4 +482,52 @@ private NameIdentifier
buildPaimonNameIdentifier(NameIdentifier identifier) {
String[] levels = identifier.namespace().levels();
return NameIdentifier.of(levels[levels.length - 1], identifier.name());
}
+
+ /**
+ * Performs rename table change with the provided identifier.
+ *
+ * @param identifier The identifier of the table to rename.
+ * @param renameTable Table Change to modify the table name.
+ * @return The renamed {@link GravitinoPaimonTable} instance.
+ * @throws NoSuchTableException If the table with the provided identifier
does not exist.
+ * @throws IllegalArgumentException This exception will not be thrown in
this method.
+ */
+ private GravitinoPaimonTable renameTable(
+ NameIdentifier identifier, TableChange.RenameTable renameTable)
+ throws NoSuchTableException, IllegalArgumentException {
+ try {
+ paimonCatalogOps.renameTable(
+ identifier.toString(),
+ NameIdentifier.of(identifier.namespace(),
renameTable.getNewName()).toString());
+ } catch (Catalog.TableNotExistException e) {
+ throw new NoSuchTableException(e, NO_SUCH_TABLE_EXCEPTION, identifier);
+ } catch (Catalog.TableAlreadyExistException e) {
+ throw new TableAlreadyExistsException(e, TABLE_ALREADY_EXISTS_EXCEPTION,
identifier);
Review Comment:
fixed
##########
catalogs/catalog-lakehouse-paimon/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/utils/TableOpsUtils.java:
##########
@@ -18,20 +18,127 @@
*/
package org.apache.gravitino.catalog.lakehouse.paimon.utils;
+import static
org.apache.gravitino.catalog.lakehouse.paimon.PaimonTablePropertiesMetadata.COMMENT;
+import static
org.apache.gravitino.catalog.lakehouse.paimon.PaimonTablePropertiesMetadata.checkReservedProperties;
+import static
org.apache.gravitino.catalog.lakehouse.paimon.utils.TypeUtils.toPaimonType;
+import static org.apache.paimon.schema.SchemaChange.addColumn;
+import static org.apache.paimon.schema.SchemaChange.dropColumn;
+import static org.apache.paimon.schema.SchemaChange.removeOption;
+import static org.apache.paimon.schema.SchemaChange.renameColumn;
+import static org.apache.paimon.schema.SchemaChange.setOption;
+import static org.apache.paimon.schema.SchemaChange.updateColumnComment;
+import static org.apache.paimon.schema.SchemaChange.updateColumnNullability;
+import static org.apache.paimon.schema.SchemaChange.updateColumnPosition;
+import static org.apache.paimon.schema.SchemaChange.updateColumnType;
+import static org.apache.paimon.schema.SchemaChange.updateComment;
+
+import com.google.common.base.Joiner;
import com.google.common.base.Preconditions;
+import java.util.ArrayList;
+import java.util.List;
import org.apache.gravitino.catalog.lakehouse.paimon.ops.PaimonCatalogOps;
import org.apache.gravitino.rel.Column;
+import org.apache.gravitino.rel.TableChange;
+import org.apache.gravitino.rel.TableChange.AddColumn;
+import org.apache.gravitino.rel.TableChange.After;
+import org.apache.gravitino.rel.TableChange.ColumnChange;
+import org.apache.gravitino.rel.TableChange.ColumnPosition;
+import org.apache.gravitino.rel.TableChange.Default;
+import org.apache.gravitino.rel.TableChange.DeleteColumn;
+import org.apache.gravitino.rel.TableChange.First;
+import org.apache.gravitino.rel.TableChange.RemoveProperty;
+import org.apache.gravitino.rel.TableChange.RenameColumn;
+import org.apache.gravitino.rel.TableChange.SetProperty;
+import org.apache.gravitino.rel.TableChange.UpdateColumnComment;
+import org.apache.gravitino.rel.TableChange.UpdateColumnNullability;
+import org.apache.gravitino.rel.TableChange.UpdateColumnPosition;
+import org.apache.gravitino.rel.TableChange.UpdateColumnType;
+import org.apache.gravitino.rel.TableChange.UpdateComment;
import org.apache.gravitino.rel.expressions.Expression;
+import org.apache.paimon.schema.SchemaChange;
+import org.apache.paimon.schema.SchemaChange.Move;
/** Utilities of {@link PaimonCatalogOps} to support table operation. */
public class TableOpsUtils {
+ public static final Joiner DOT = Joiner.on(".");
+
public static void checkColumnCapability(
String fieldName, Expression defaultValue, boolean autoIncrement) {
checkColumnDefaultValue(fieldName, defaultValue);
checkColumnAutoIncrement(fieldName, autoIncrement);
}
+ public static List<SchemaChange> buildSchemaChanges(TableChange...
tableChanges)
+ throws UnsupportedOperationException {
+ List<SchemaChange> schemaChanges = new ArrayList<>();
+ for (TableChange tableChange : tableChanges) {
+ schemaChanges.add(buildSchemaChange(tableChange));
+ }
+ return schemaChanges;
+ }
+
+ public static SchemaChange buildSchemaChange(TableChange tableChange)
+ throws UnsupportedOperationException {
+ if (tableChange instanceof ColumnChange) {
+ String[] fieldNames = ((ColumnChange) tableChange).fieldName();
+ checkNestedColumn(fieldNames);
+
+ if (tableChange instanceof AddColumn) {
+ AddColumn addColumn = (AddColumn) tableChange;
+ String fieldName = fieldName(addColumn);
+ checkColumnCapability(fieldName, addColumn.getDefaultValue(),
addColumn.isAutoIncrement());
+ return addColumn(
+ fieldName,
+ toPaimonType(addColumn.getDataType()).copy(addColumn.isNullable()),
+ addColumn.getComment(),
+ move(fieldName, addColumn.getPosition()));
+ } else if (tableChange instanceof DeleteColumn) {
+ return dropColumn(fieldName((DeleteColumn) tableChange));
+ } else if (tableChange instanceof RenameColumn) {
+ RenameColumn renameColumn = ((RenameColumn) tableChange);
+ return renameColumn(fieldName(renameColumn),
renameColumn.getNewName());
+ } else if (tableChange instanceof UpdateColumnComment) {
+ UpdateColumnComment updateColumnComment = (UpdateColumnComment)
tableChange;
+ return updateColumnComment(
+ fieldName(updateColumnComment),
updateColumnComment.getNewComment());
+ } else if (tableChange instanceof UpdateColumnNullability) {
+ UpdateColumnNullability updateColumnNullability =
(UpdateColumnNullability) tableChange;
+ return updateColumnNullability(
+ fieldName(updateColumnNullability),
updateColumnNullability.nullable());
+ } else if (tableChange instanceof UpdateColumnPosition) {
+ UpdateColumnPosition updateColumnPosition = (UpdateColumnPosition)
tableChange;
+ return updateColumnPosition(
+ move(fieldName(updateColumnPosition),
updateColumnPosition.getPosition()));
+ } else if (tableChange instanceof UpdateColumnType) {
+ UpdateColumnType updateColumnType = (UpdateColumnType) tableChange;
+ return updateColumnType(
+ fieldName(updateColumnType),
toPaimonType(updateColumnType.getNewDataType()));
+ }
+ } else if (tableChange instanceof UpdateComment) {
+ return updateComment(((UpdateComment) tableChange).getNewComment());
+ } else if (tableChange instanceof SetProperty) {
+ SetProperty setProperty = ((SetProperty) tableChange);
+ String setPropertyKey = setProperty.getProperty();
+ checkReservedProperties(setPropertyKey);
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
