mchades commented on code in PR #4343: URL: https://github.com/apache/gravitino/pull/4343#discussion_r1703923739
########## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java: ########## Review Comment: It's not enough, you should also override the method `tablePropertiesMetadata` in `DorisCatalog` to return the `DorisTablePropertiesMetadata` instance. ########## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/DorisTablePropertiesMetadata.java: ########## Review Comment: BTW, the tests and docs also need to be added -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
