FANNG1 commented on code in PR #4273:
URL: https://github.com/apache/gravitino/pull/4273#discussion_r1701111043


##########
iceberg/iceberg-rest-server/src/test/java/org/apache/gravitino/iceberg/service/rest/IcebergRestTestUtil.java:
##########
@@ -66,13 +69,20 @@ public static ResourceConfig getIcebergResourceConfig(Class 
c, boolean bindIcebe
     }
 
     if (bindIcebergTableOps) {
-      IcebergTableOps icebergTableOps = new IcebergTableOpsForTest();
+      Map<String, String> catalogConf = Maps.newHashMap();
+      catalogConf.put(String.format("catalog.%s.xx", PREFIX), "xxx");
+      catalogConf.put(
+          IcebergConstants.ICEBERG_REST_CATALOG_PROVIDER,
+          ConfigIcebergTableOpsProviderForTest.class.getName());
+      IcebergConfig icebergConfig = new IcebergConfig(catalogConf);
+      IcebergTableOpsManager icebergTableOpsManager = new 
IcebergTableOpsManager(icebergConfig);

Review Comment:
   how to verify the test works well for prefix and non-prefix request?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to