yuqi1129 commented on code in PR #4167:
URL: https://github.com/apache/gravitino/pull/4167#discussion_r1696625092
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -69,6 +69,20 @@ public class GravitinoConfig {
"true",
false);
+ private static final ConfigEntry GRAVITINO_CLOUD_REGION_CODE =
+ new ConfigEntry(
+ "gravitino.cloud.region-code",
+ "The property to specify the region code of the cloud that the
catalog is running on.",
+ "",
+ false);
+
+ private static final ConfigEntry
GRAVITINO_CATALOG_CONNECTOR_FACTORY_CLASS_NAME =
+ new ConfigEntry(
+ "gravitino.catalog.connector.factory.class.name",
+ "The class name for the special CatalogConnectorFactory.",
Review Comment:
for the special -> custom
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConfig.java:
##########
@@ -69,6 +69,20 @@ public class GravitinoConfig {
"true",
false);
+ private static final ConfigEntry GRAVITINO_CLOUD_REGION_CODE =
+ new ConfigEntry(
+ "gravitino.cloud.region-code",
+ "The property to specify the region code of the cloud that the
catalog is running on.",
+ "",
+ false);
+
+ private static final ConfigEntry
GRAVITINO_CATALOG_CONNECTOR_FACTORY_CLASS_NAME =
+ new ConfigEntry(
+ "gravitino.catalog.connector.factory.class.name",
+ "The class name for the special CatalogConnectorFactory.",
Review Comment:
Please add the following contents.
The specific class should implement interface `CatalogConnectorFactory`
##########
trino-connector/src/main/java/org/apache/gravitino/trino/connector/GravitinoConnectorFactory.java:
##########
@@ -120,4 +124,20 @@ public Connector create(
Supplier<GravitinoAdminClient> clientProvider() {
return () -> null;
}
+
+ CatalogConnectorFactory createCatalogConnectorFactory(GravitinoConfig
config) {
Review Comment:
Please add some comments on this method and highlight the point that we can
support custom catalog connector factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
