jerryshao commented on code in PR #4093:
URL: https://github.com/apache/gravitino/pull/4093#discussion_r1670058240
##########
clients/client-python/gravitino/utils/http_client.py:
##########
@@ -154,19 +177,38 @@ def _request(
self.auth_data_provider.get_token_data().decode("utf-8"),
)
request.get_method = lambda: method
- return Response(self._make_request(opener, request, timeout=timeout))
-
- def get(self, endpoint, params=None, **kwargs):
- return self._request("get", endpoint, params=params, **kwargs)
-
- def delete(self, endpoint, **kwargs):
- return self._request("delete", endpoint, **kwargs)
-
- def post(self, endpoint, json=None, **kwargs):
- return self._request("post", endpoint, json=json, **kwargs)
-
- def put(self, endpoint, json=None, **kwargs):
- return self._request("put", endpoint, json=json, **kwargs)
+ is_success, resp = self._make_request(opener, request, timeout=timeout)
+
+ if is_success:
+ return resp
+
+ if not isinstance(error_handler, ErrorHandler):
+ raise UnknownError(
+ f"Unknown error handler {type(error_handler).__name__}, error
response body: {resp}"
+ ) from None
+
+ error_handler.handle(resp)
+ raise UnknownError(
+ f"Error handler {type(error_handler).__name__} can't handle this
response, error response body: {resp}"
+ ) from None
Review Comment:
I assume that `error_handler.handle(resp)` will handle all the error cases,
how can we reach to this point? From my understanding that code will never
reach to here, am I right?
```
raise UnknownError(
f"Error handler {type(error_handler).__name__} can't handle this
response, error response body: {resp}"
) from None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
