SemyonSinchenko commented on code in PR #982:
URL: https://github.com/apache/incubator-graphar/pull/982#discussion_r4274706891
##########
maven-projects/io-parquet/src/main/java/org/apache/graphar/io/parquet/ParquetBatchCursor.java:
##########
@@ -330,34 +348,67 @@ private BlockRange nextRange() {
rowGroup.index,
begin - rowGroup.start,
end - rowGroup.start,
- begin == rowGroup.start && end == rowGroup.end);
+ begin == rowGroup.start && end == rowGroup.end,
+ rowGroup.indexed);
}
}
return null;
}
- private static List<BlockRange> rowGroups(List<BlockMetaData> blocks) {
+ private boolean indexedPartialRowGroups() {
Review Comment:
This method re-implements the partial-overlap predicate (`begin < end &&
(begin != rowGroup.start || end != rowGroup.end)`) that `nextRange()` also
encodes in negated form for the `whole` flag (`begin == rowGroup.start && end
== rowGroup.end`). The two copies currently agree, but this predicate decides
the public `rowRangeApplied()` result (and hence the ReadReport's
applied/declined ROW_RANGE), while the copy in `nextRange()` decides the actual
slice-in-memory fallback. If a future edit changes one site without the other,
the report could claim the row range was physically pushed down while a group
is in fact being sliced in memory. Extract the predicate into a shared helper
used by both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
