SYaoJun commented on code in PR #925:
URL: https://github.com/apache/incubator-graphar/pull/925#discussion_r3273524060
##########
cpp/README.md:
##########
@@ -88,35 +88,22 @@ cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTS=ON ..
make -j8 # if you have 8 CPU cores, otherwise adjust, use -j`nproc` for
all cores
```
-### Quick Build with Scripts
+### Quick Build with CMake Presets
-For convenience, we provide build scripts for Ubuntu and macOS that configure
the following CMake options:
+We use CMake Presets for quick building. Available presets:
-- `-DBUILD_BENCHMARKS=ON`: Build benchmark executables
-- `-DCMAKE_BUILD_TYPE=Debug`: Build in debug mode
-- `-DBUILD_TESTS=ON`: Build unit tests
-- `-DBUILD_EXAMPLES=ON`: Build example executables
+- `debug` - Debug build with tests, examples, and benchmarks
+- `release` - Release build with tests, examples, and benchmarks
-**Ubuntu:**
```bash
-./build_ubuntu.sh
-```
-
-**macOS:**
-```bash
-./build_macos.sh
-```
+# Configure the project
+cmake --preset debug # or: cmake --preset release
-These scripts will automatically create the build directory, configure with
CMake, and compile the project. Build logs will be saved to `build_ubuntu.log`
or `build_macos.log`.
-
-After building, you can run the unit tests with:
-
-```bash
-git submodule update --init --recursive # download the testing data
-GAR_TEST_DATA=${PWD}/testing ctest
+# Build the project
+cmake --build --preset debug # or: cmake --build --preset release
```
Review Comment:
restored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]