Copilot commented on code in PR #908:
URL: https://github.com/apache/incubator-graphar/pull/908#discussion_r3201436521
##########
python/README.md:
##########
@@ -1,12 +1,12 @@
# GraphAr Python SDK
-GraphAr Python SDK provides Python bindings for the GraphAr C++ library,
allowing user to work with GraphAr formatted graph data in Python environments.
It includes both a high-level API for data manipulation and a command-line
interface for common operations.
+GraphAr Python SDK provides Python bindings for the GraphAr C++ library,
allowing users to work with GraphAr formatted graph data in Python
environments. It includes both a high-level API for data manipulation and a
command-line interface for common operations.
## Installation
### Prerequisites
-- Python >= 3.7
+- Python >= 3.9
- pip (latest version recommended)
Review Comment:
The Python version requirement is updated here to ">= 3.9", but other docs
in the repo still state ">= 3.7" (e.g. python/src/cli/README.md). Please align
those documents so users don’t get conflicting guidance about supported Python
versions.
##########
.github/workflows/python-wheel-workflow.yml:
##########
@@ -114,6 +114,8 @@ jobs:
CIBW_PLATFORM: ${{ matrix.os }}
CIBW_BUILD: "cp39-* cp310-* cp311-* cp312-* cp313-*"
CIBW_SKIP: "*-musllinux_*"
+ # Use uv on macOS to avoid transient GitHub rate limits when cibuildwheel
+ CIBW_BUILD_FRONTEND: ${{ matrix.os == 'macos' && 'build[uv]' || 'build'
}}
# Pin arch to the matrix platform
CIBW_ARCHS: ${{ matrix.platform }}
Review Comment:
This sets CIBW_BUILD_FRONTEND for all matrix entries: macOS gets "build[uv]"
but Linux now explicitly gets "build" (previously the variable was unset). If
the intent is only to change macOS behavior, consider scoping this env var to
macOS only (or leaving non-macOS unset) to avoid unintended changes in how
wheels are built on other platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
