SYaoJun commented on PR #861: URL: https://github.com/apache/incubator-graphar/pull/861#issuecomment-3984517435
## Added LRU Cache [benchmark](https://github.com/apache/incubator-graphar/actions/runs/22577682031/job/65401070442?pr=861) ## Summary After adding the cache, the initialization and creation times have increased. Since filtering and selection operations affect the cache, we currently invalidate all caches aggressively. This has caused performance regressions in filter operations. I believe this issue requires a more careful design—there is still significant room for substantial improvement. ### Performance Improvements | Benchmark | Before (ns) | After (ns) | Improvement | |-----------|-------------|------------|-------------| | AdjListPropertyArrowChunkReaderReadChunk | 166224 | 3927 | 42.33x | | AdjListArrowChunkReaderReadChunk | 152848 | 6095 | 25.08x | | AdjListOffsetArrowChunkReaderReadChunk | 136690 | 3808 | 35.90x | | VertexPropertyArrowChunkReaderReadChunk_firstGraph_AllColumns_V1 | 189591 | 10307 | 18.39x | | VertexPropertyArrowChunkReaderReadChunk_firstGraph_TwoColumns_V1 | 201011 | 7756 | 25.92x | | VertexPropertyArrowChunkReaderReadChunk_firstGraph_OneColumns_V1 | 179371 | 6139 | 29.22x | | VertexPropertyArrowChunkReaderReadChunk_firstGraph_AllColumns_V2 | 133497 | 9883 | 13.51x | | VertexPropertyArrowChunkReaderReadChunk_firstGraph_TwoColumns_V2 | 108899 | 7876 | 13.83x | | VertexPropertyArrowChunkReaderReadChunk_firstGraph_OneColumns_V2 | 82066 | 5830 | 14.08x | | VertexPropertyArrowChunkReaderReadChunk_secondGraph_AllColumns_V1 | 396302 | 10402 | 38.10x | | VertexPropertyArrowChunkReaderReadChunk_secondGraph_TwoColumns_V1 | 301181 | 8218 | 36.65x | | VertexPropertyArrowChunkReaderReadChunk_secondGraph_OneColumns_V1 | 191486 | 5875 | 32.59x | | VertexPropertyArrowChunkReaderReadChunk_secondGraph_AllColumns_V2 | 775914 | 9723 | 79.80x | | VertexPropertyArrowChunkReaderReadChunk_secondGraph_TwoColumns_V2 | 462362 | 8328 | 55.52x | | VertexPropertyArrowChunkReaderReadChunk_secondGraph_OneColumns_V2 | 188513 | 5899 | 31.96x | ### Minor Performance Changes | Benchmark | Before (ns) | After (ns) | Ratio | |-----------|-------------|------------|-------| | CreateAdjListArrowChunkReader | 3577 | 38150 | 0.09x | | CreateAdjListOffsetArrowChunkReader | 3550 | 38338 | 0.09x | ### Performance Regressions | Benchmark | Before (ns) | After (ns) | Regression | |-----------|-------------|------------|------------| | InitialGraphInfo | 202816 | 1824996 | 0.11x | | CreateVertexPropertyArrowChunkReader | 6965 | 79185 | 0.09x | | SingleLabelFilter | 111611 | 1710060 | 0.07x | | SingleLabelFilterbyAcero | 658114 | 2487584 | 0.26x | | MultiLabelFilter | 92712 | 1271051 | 0.07x | | MultiLabelFilterbyAcero | 465075 | 1909993 | 0.24x | | LabelFilterFromSet | 48985 | 824111 | 0.06x | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
