Sober7135 commented on PR #878:
URL:
https://github.com/apache/incubator-graphar/pull/878#issuecomment-3961500773
Nice work! The Rust CI failure is caused by API breakage, so you don’t need
to worry about it. I’ll review this PR later.
Before that, though, I think we should discuss the API breakage with
@yangxk1 first.
Any thoughts? CC @yangxk1
1. What type should we choose (`size_t` vs `int32_t`, etc.)?
2. How should we handle the API breakage?
* just break it
* or first mark the old APIs as deprecated, add a new v2 API, and
document the upgrade path in the roadmap
* ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
