Copilot commented on code in PR #862:
URL: https://github.com/apache/incubator-graphar/pull/862#discussion_r2844151144
##########
.pre-commit-config.yaml:
##########
@@ -54,15 +58,12 @@ repos:
types_or: [c++, c]
- repo: https://github.com/compilerla/conventional-pre-commit
- rev: v3.0.0
+ rev: v4.3.0
hooks:
- id: conventional-pre-commit
- stages: [ commit-msg ]
- args: [
- --types,feat,fix,docs,style,refactor,test,chore,perf,ci,build,revert,
- --scope-optional
- ]
-
+ stages: [commit-msg]
+ args: [--verbose]
Review Comment:
The removal of explicit types configuration (feat, fix, docs, style,
refactor, test, chore, perf, ci, build, revert) and the --scope-optional flag
needs clarification.
In the old configuration (v3.0.0), these types were explicitly allowed and
scope was optional. The new configuration only specifies --verbose, which means
the tool will use its default types.
Please verify that:
1. The default types in conventional-pre-commit v4.3.0 include all the types
that were previously configured (especially 'chore' which is used in this PR's
title)
2. The scope is still optional by default in v4.3.0, or if an explicit
--scope-optional flag is needed
If the default behavior has changed between v3.0.0 and v4.3.0, this could
break existing workflows or reject valid commit messages that were previously
accepted.
```suggestion
args:
- --verbose
- --scope-optional
- --types
- feat
- fix
- docs
- style
- refactor
- test
- chore
- perf
- ci
- build
- revert
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
