Sober7135 commented on PR #857:
URL: 
https://github.com/apache/incubator-graphar/pull/857#issuecomment-3907885119

   Actually, I’m not very familiar with dependency handling, so this is a bit 
of an immature/personal suggestion.
   
   Maybe we should rely fully on pkg-config, rather than `ARROW_HOME` and 
`ARROW_LIB_DIR`, since:
   - Arrow always provides a *.pc file.
   - We can get `CMAKE_PREFIX_PATH` via `pkg-config --variable=prefix arrow` 
(in Rust: `pkg_config::get_variable("arrow", "prefix")`).
   - We can link Arrow via: 
`pkg_config::Config::new().statik(true).cargo_metadata(true)`
   
   If the `*.pc` file isn’t in a standard location (e.g. 
`/usr/share/pkgconfig`), we can set `PKG_CONFIG_PATH`.
   
   For example:
   For example, if Arrow is installed at `/opt/arrow` and the `pkgconfig` files 
are under `/opt/arrow/lib64/pkgconfig`:
   ```bash
   export PKG_CONFIG_PATH="/opt/arrow/lib64/pkgconfig:${PKG_CONFIG_PATH}" # set 
`PKG_CONFIG_PATH`
   pkg-config --variable=prefix arrow
   # output: /opt/arrow
   ```
   
   Any thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to