Thespica commented on code in PR #776: URL: https://github.com/apache/incubator-graphar/pull/776#discussion_r2468784908
########## cpp/extensions/kuzu-extension/README.md: ########## @@ -0,0 +1,118 @@ +# Kuzu — GraphAr Extension + +**API:** C++ +**Status:** first-cut, pragmatic implementation (ingest, export, metadata inspection) +**Repository branch:** [https://github.com/gary-cloud/kuzu/tree/graphar-extension](https://github.com/gary-cloud/kuzu/tree/graphar-extension) Review Comment: Switch to https://github.com/apache/incubator-graphar/tree/kuzu-extension ########## cpp/extensions/kuzu-extension/test/graphar_extension_metadata_test.cpp: ########## @@ -0,0 +1,106 @@ +#include <iostream> +#include <filesystem> +#include <memory> +#include <string> +#include "kuzu.hpp" + +using namespace std; +using namespace kuzu::main; // Database, Connection, QueryResult +using namespace kuzu::common; // Value, LogicalTypeID +using namespace kuzu::processor; // ResultSet, FlatTuple + +#include <kuzu.hpp> +#include <iostream> +#include <memory> + +using namespace std; +using namespace kuzu; +using namespace kuzu::common; + +#include <kuzu.hpp> +#include <iostream> +#include <memory> + +using namespace std; Review Comment: avoid using `namespace std`, using `std::xxx` even if in test ########## cpp/extensions/kuzu-extension/test/graphar_extension_copy_test.cpp: ########## @@ -0,0 +1,120 @@ +#include <iostream> +#include <filesystem> +#include "kuzu.hpp" + +using namespace kuzu::main; +using namespace std; Review Comment: do it too ########## cpp/extensions/kuzu-extension/test/graphar_extension_copy_to_test.cpp: ########## @@ -0,0 +1,140 @@ +#include <iostream> +#include <filesystem> +#include "kuzu.hpp" + +using namespace kuzu::main; +using namespace std; Review Comment: do it too ########## cpp/extensions/kuzu-extension/test/graphar_extension_load_test.cpp: ########## @@ -0,0 +1,67 @@ +#include <iostream> +#include <filesystem> +#include "kuzu.hpp" + +using namespace kuzu::main; +using namespace std; Review Comment: do it too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
