Sober7135 commented on code in PR #777:
URL: https://github.com/apache/incubator-graphar/pull/777#discussion_r2384056239
##########
cpp/src/graphar/high-level/graph_reader.h:
##########
@@ -905,9 +906,7 @@ class EdgesCollection {
explicit EdgesCollection(const std::shared_ptr<EdgeInfo>& edge_info,
const std::string& prefix, IdType
vertex_chunk_begin,
IdType vertex_chunk_end, AdjListType adj_list_type)
- : edge_info_(std::move(edge_info)),
Review Comment:
Using `std::move` converts `const std::shared_ptr<EdgeInfo>&` to `const
std::shared_ptr<EdgeInfo>&&`, but `std::shared_ptr` has no constructor that
takes`const std::shared_ptr &&`. This causes a fallback to another constructor.
We should remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
