yangxk1 commented on PR #764:
URL:
https://github.com/apache/incubator-graphar/pull/764#issuecomment-3337017869
Hi @Jarvx200 , I think some simplicity can be wasted in order to keep it
easy to read. We can add a builder method in `propertyGroups` , than we can call
```
public EdgeInfo/VerterxBuilder propertyGroups(PropertyGroups propertyGroups){
propertyBuilder(properyGroups);
}
public EdgeInfo/VerterxBuilder propertyGroups(PropertyGroup propertyGroup){
propertyBuilder(propertyGroup);
}
```
in both `VertexBuilder` and `EdgeBuilder`.
However, for `ElementGenericAbstractBuilder.java`, In order to simplify
`version` and `prefix` in `builder`, we have introduced such complex methods.
Is this worth it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
