gary-cloud opened a new pull request, #754: URL: https://github.com/apache/incubator-graphar/pull/754
<!-- Thanks for contributing to GraphAr. If this is your first pull request you can find detailed information on [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md) The Apache GraphAr (incubating) community has restrictions on the naming of pr title. You can find instructions in [CONTRIBUTING.md](https://github.com/apache/graphar/blob/main/CONTRIBUTING.md#title) too. --> ### Reason for this PR <!-- Why are you proposing this change? If this is already tracked in an issue, please link to the issue here. Explaining clearly why this change is beneficial is important for the reviewers to understand the context. --> Previously, `vertexIter` and `edgeIter` did not properly support `date32` and `timestamp(MILLI)` property types. ### What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> * Added explicit handling for `arrow::date32` and `arrow::timestamp(MILLI)` types in `GetArrowArrayData`. * Kept the existing default branch to raise a `Status::TypeError` if the array type is unsupported. ### Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Yes ### Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking. --> <!-- **BREAKING CHANGE: <description>** --> Yes, user-facing improvement: Users can now reliably access `date32` and `timestamp(MILLI)` properties through iterators (`vertexIter` / `edgeIter`). No breaking changes introduced; unsupported types still return a `TypeError` as before. ```c++ // sample code for timestamp type it.property<int64_t>("creationDate").value(); // sample code for date type it.property<int32_t>("creationDate").value(); ``` <!-- Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious. --> <!-- **Critical Fix: <description>** --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
