yangxk1 commented on code in PR #710:
URL: https://github.com/apache/incubator-graphar/pull/710#discussion_r2179810333
##########
maven-projects/info/src/main/java/org/apache/graphar/info/GraphInfo.java:
##########
@@ -112,10 +113,62 @@ public Optional<GraphInfo> addVertexAsNew(VertexInfo
vertexInfo) {
cachedEdgeInfoMap));
}
+ public Optional<GraphInfo> removeEdge(EdgeInfo edgeInfo) {
Review Comment:
I think it would be better to align the parameters with
[getEdgeInfo](https://github.com/apache/incubator-graphar/tree/main/maven-projects/info/src/main/java/org/apache/graphar/info/GraphInfo.java#L157),(`srcLabel`,
`edgeLabel`, `dstLabel`).
##########
maven-projects/info/src/main/java/org/apache/graphar/info/GraphInfo.java:
##########
@@ -112,10 +113,62 @@ public Optional<GraphInfo> addVertexAsNew(VertexInfo
vertexInfo) {
cachedEdgeInfoMap));
}
+ public Optional<GraphInfo> removeEdge(EdgeInfo edgeInfo) {
+ if (edgeInfo == null
+ || hasEdgeInfo(
+ edgeInfo.getSrcLabel(), edgeInfo.getEdgeLabel(),
edgeInfo.getDstLabel())) {
+ return Optional.empty();
+ }
+ final org.apache.graphar.proto.GraphInfo newProtoGraphInfo =
+ org.apache.graphar.proto.GraphInfo.newBuilder(protoGraphInfo)
+ .removeEdges(edgeInfo.getEdgePath())
Review Comment:
Does this method exist?
##########
maven-projects/info/src/main/java/org/apache/graphar/info/GraphInfo.java:
##########
@@ -112,10 +113,62 @@ public Optional<GraphInfo> addVertexAsNew(VertexInfo
vertexInfo) {
cachedEdgeInfoMap));
}
+ public Optional<GraphInfo> removeEdge(EdgeInfo edgeInfo) {
Review Comment:
It may be better to name it `removeEdgeAsNew`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
