yangxk1 commented on code in PR #683:
URL: https://github.com/apache/incubator-graphar/pull/683#discussion_r2111361763
##########
maven-projects/info/src/test/java/org/apache/graphar/info/GraphLoaderTest.java:
##########
@@ -41,21 +44,196 @@ public static void clean() {}
public void testLoad() {
final GraphLoader graphLoader = new LocalYamlGraphLoader();
final String GRAPH_PATH = TestUtil.getLdbcSampleGraphPath();
+ GraphInfo graphInfo = null;
try {
- final GraphInfo graphInfo = graphLoader.load(GRAPH_PATH);
- Assert.assertNotNull(graphInfo);
- Assert.assertNotNull(graphInfo.getEdgeInfos());
- Assert.assertEquals(1, graphInfo.getEdgeInfos().size());
- for (EdgeInfo edgeInfo : graphInfo.getEdgeInfos()) {
- Assert.assertNotNull(edgeInfo.getConcat());
- }
- Assert.assertNotNull(graphInfo.getVertexInfos());
- Assert.assertEquals(1, graphInfo.getVertexInfos().size());
- for (VertexInfo vertexInfo : graphInfo.getVertexInfos()) {
- Assert.assertNotNull(vertexInfo.getType());
- }
+ graphInfo = graphLoader.load(GRAPH_PATH);
} catch (IOException e) {
throw new RuntimeException(e);
}
+ testGraphInfo(graphInfo);
+ testVertexInfo(graphInfo);
+ testEdgeInfo(graphInfo);
+ }
+
+ private void testGraphInfo(GraphInfo graphInfo) {
+ Assert.assertNotNull(graphInfo);
+ Assert.assertEquals("ldbc_sample", graphInfo.getName());
+ Assert.assertEquals("", graphInfo.getPrefix()); // is empty string?
+ Assert.assertNotNull(graphInfo.getEdgeInfos());
+ Assert.assertEquals(1, graphInfo.getEdgeInfos().size());
+ Assert.assertNotNull(graphInfo.getVertexInfos());
+ Assert.assertEquals(1, graphInfo.getVertexInfos().size());
+ }
+
+ private void testVertexInfo(GraphInfo graphInfo) {
+ VertexInfo personVertexInfo = graphInfo.getVertexInfos().get(0);
+ Assert.assertEquals("person", personVertexInfo.getType());
+ Assert.assertEquals(100, personVertexInfo.getChunkSize());
+ Assert.assertEquals("vertex/person/", personVertexInfo.getPrefix());
+ Assert.assertEquals(
+ "vertex/person//vertex_count",
+ personVertexInfo.getVerticesNumFilePath()); // one more '/'
+ Assert.assertEquals("vertex/person//person.vertex.yaml",
personVertexInfo.getVertexPath());
+ Assert.assertNotNull(personVertexInfo.getPropertyGroups());
+ Assert.assertEquals(2, personVertexInfo.getPropertyGroups().size());
Review Comment:
I have refactored the test code by splitting it into multiple test methods.
I think this is clearer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@graphar.apache.org
For additional commands, e-mail: commits-h...@graphar.apache.org
