Elssky commented on PR #607: URL: https://github.com/apache/incubator-graphar/pull/607#issuecomment-2370583523
> Hi, @Elssky, thanks for the contribution, I have roughly review the PR and leaved some comments. To make the PR more clear and elegant， I highly recommend that > > * Add document or update the document if you add new API or break down the current API > * Don't make this feature as a HUGE PR if you can split the feature into some sub-feature. That would make reviewing easier and help to back track. yes, I seperate this PR to https://github.com/apache/incubator-graphar/pull/634 and https://github.com/apache/incubator-graphar/pull/635/commits/8813288622876441693219053ae6f9f324bffddf -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
